Update application shutdown logic #1760
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yavor16
force-pushed
the
application-shutdown-logic-update
branch
2 times, most recently
from
31b61f2 to
8da103c
Compare
theghost5800
reviewed
Jan 7, 2026
...loudfoundry/multiapps/controller/core/application/shutdown/ApplicationShutdownScheduler.java
Outdated
Show resolved
Hide resolved
...iapps-controller-core/src/main/java/org/cloudfoundry/multiapps/controller/core/Messages.java
Outdated
Show resolved
Hide resolved
...loudfoundry/multiapps/controller/core/application/shutdown/ApplicationShutdownScheduler.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/cloudfoundry/multiapps/controller/persistence/dto/ApplicationShutdown.java
Outdated
Show resolved
Hide resolved
.../main/java/org/cloudfoundry/multiapps/controller/persistence/dto/ApplicationShutdownDto.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/org/cloudfoundry/multiapps/controller/shutdown/client/util/ShutdownUtil.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/org/cloudfoundry/multiapps/controller/shutdown/client/util/ShutdownUtil.java
Outdated
Show resolved
Hide resolved
| instanceShutdownExecutor.execute(applicationGuid, i); | ||
| public void execute(String applicationId, int applicationInstanceCount) { | ||
| ApplicationShutdownScheduler applicationShutdownScheduler = getApplicationShutdownScheduler(); | ||
| List<ApplicationShutdown> scheduledApplicationShutdowns = applicationShutdownScheduler.scheduleApplicationForShutdown(applicationId, |
Contributor
There was a problem hiding this comment.
What will happen if count of instances is mistaken or some of existing instances are in crashed/not running state? Will it lead to infinite loop?
Contributor
Author
There was a problem hiding this comment.
i dont it will because if an instance has crashed on startup, the instance will delete the scheduled entry from the database so there won't be attempts for shutdown.
also if we scheduled 5 instances for shutdown but in reality there are 3, we will shutdown the intances from 1-3. the entries for shutdown for instance 4 and 5 won't be cleared from the database. when we increase the instances back to 5, the scheduled entries will be cleared from the database.
If we schedule 3 instances but there are 5, only the first 3 will be shutdown. the other 2 won't be shutdown
...in/java/org/cloudfoundry/multiapps/controller/web/resources/ApplicationShutdownResource.java
Show resolved
Hide resolved
stiv03
suggested changes
Jan 8, 2026
...-web/src/main/java/org/cloudfoundry/multiapps/controller/web/bootstrap/BootstrapServlet.java
Outdated
Show resolved
Hide resolved
...loudfoundry/multiapps/controller/core/application/shutdown/ApplicationShutdownScheduler.java
Outdated
Show resolved
Hide resolved
...a/org/cloudfoundry/multiapps/controller/persistence/services/ApplicationShutdownService.java
Outdated
Show resolved
Hide resolved
.../main/java/org/cloudfoundry/multiapps/controller/persistence/dto/ApplicationShutdownDto.java
Show resolved
Hide resolved
...g/cloudfoundry/multiapps/controller/persistence/query/impl/ApplicationShutdownQueryImpl.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/cloudfoundry/multiapps/controller/process/jobs/ApplicationShutdownJob.java
Outdated
Show resolved
Hide resolved
Comment on lines
69
to
83
| private void shutdownApplication(ApplicationShutdown applicationShutdown) { | ||
| CompletableFuture.runAsync(() -> { | ||
| logProgressOfShuttingDown(applicationShutdown, Messages.SHUTTING_DOWN_APPLICATION_WITH_ID_AND_INDEX); | ||
| flowableFacade.shutdownJobExecutor(); | ||
| }) | ||
| .thenRun(() -> logProgressOfShuttingDown(applicationShutdown, Messages.SHUT_DOWN_APPLICATION_WITH_ID_AND_INDEX)); | ||
| } |
Contributor
There was a problem hiding this comment.
Is it possible here, exception to be thrown inside the async task, this will impact the DB state in a wrong way. Maybe add FAILED status for such cases.
Contributor
|
Also add some unit tests, cause now there is 0.0% Coverage on New Code |
Yavor16
force-pushed
the
application-shutdown-logic-update
branch
2 times, most recently
from
4f3dab1 to
aea5e01
Compare
LMCROSSITXSADEPLOY-3344 # Conflicts: # multiapps-controller-process/src/main/java/org/cloudfoundry/multiapps/controller/process/Messages.java # Conflicts: # multiapps-controller-core/src/main/java/org/cloudfoundry/multiapps/controller/core/Messages.java # multiapps-controller-web/src/main/java/org/cloudfoundry/multiapps/controller/web/resources/ApplicationShutdownResource.java
Yavor16
force-pushed
the
application-shutdown-logic-update
branch
from
aea5e01 to
1879759
Compare
Yavor16
force-pushed
the
application-shutdown-logic-update
branch
from
1879759 to
22db5eb
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.